fix null module externals #14118
Merged
fix null module externals #14118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
sokra
force-pushed
the
bugfix/multiple-module-externals
branch
from
edb8c73
to
4d9b955
Compare
sokra
force-pushed
the
bugfix/multiple-module-externals
branch
from
4d9b955
to
b50d033
Compare
|
@sokra The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from azure (6 errors / 0 warnings) and appveyor (success) and fix these issues. |
sokra
commented
Sep 3, 2021
| @@ -400,7 +405,7 @@ class ExternalModule extends Module { | |||
| * @returns {string} a unique identifier of the module | |||
| */ | |||
| identifier() { | |||
| return "external " + JSON.stringify(this.request); | |||
| return `external ${this.externalType} ${JSON.stringify(this.request)}`; | |||
There was a problem hiding this comment.
might fix vercel/next.js#28567
need to verify that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing