Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track and resolve symlinks when reading context timestamps/hashes #14019

Merged
merged 1 commit into from Aug 18, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 18, 2021

refactor context snapshotting for abstraction purposes
add (symlink) unit test cases for FileSystemInfo snapshotting

fixes #12246

This allows symlinks to be correctly snapshotted by FileSystemInfo.

  • circular references are eliminated
  • context that includes a symlinked directory will include content of that directory
  • For all snapshotting modes (timestamps, hashes, or both)

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

refactor context snapshotting for abstraction purposes
add (symlink) unit test cases for FileSystemInfo snapshotting
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSystemInfo can not createSnapshot with symbol link
2 participants