update webpack-sources for performance problem in hashing #13828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
add `stats.reasonsSpace` and `stats.groupReasonsByOrigin` to control large set of reasons `detailed` preset limites all spaces to 1000 by default fixes #13825
sokra
force-pushed
the
perf/many-replacements
branch
from
67e7729
to
d3f8e16
Compare
|
@sokra The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from azure (0 errors / 0 warnings) and appveyor (failure) and fix these issues. |
|
I've created an issue to document this in webpack/webpack.js.org. |
| // return true; | ||
| // }) | ||
| // ); | ||
| // }, |
There was a problem hiding this comment.
@sokra Forgot to remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
stats.reasonsSpaceandstats.groupReasonsByOriginto control large set of reasonsdetailedpreset limits all spaces to 1000 by defaultfixes #13825
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
stats.reasonsSpaceandstats.groupReasonsByOrigindetailedpreset limits all spaces to 1000 by default