Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data URI for image/svg+xml #13807

Merged
merged 4 commits into from Jul 16, 2021
Merged

fix: data URI for image/svg+xml #13807

merged 4 commits into from Jul 16, 2021

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix webpack-contrib/css-loader#1342

Did you add tests for your changes?

yes

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link
Member Author

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, we have couple bugs in our regexp, but I will fix them late, I think better to have simple parser on this

@sokra sokra merged commit e5570ab into main Jul 16, 2021
@sokra sokra deleted the issue-1342-from-css-loader branch July 16, 2021 19:56
@sokra
Copy link
Member

sokra commented Jul 16, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants