Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add wasm examples to ToC #13591

Merged
merged 2 commits into from Jun 21, 2021
Merged

doc: add wasm examples to ToC #13591

merged 2 commits into from Jun 21, 2021

Conversation

gthb
Copy link
Contributor

@gthb gthb commented Jun 18, 2021

The wasm-simple and wasm-complex examples were missing from the examples/README.md table of contents. This adds them, in a new WebAssembly section, with brief descriptions.

What kind of change does this PR introduce?

Documentation

Did you add tests for your changes?

Not applicable.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

The changes are documentation. Nothing more is needed.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Cannot see any good reason that the CI tests timed out, so I am assuming it was a transient thing and doing this to rerun them.
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra closed this Jun 21, 2021
@sokra sokra reopened this Jun 21, 2021
@sokra
Copy link
Member

sokra commented Jun 21, 2021

Could you sign the CLA: https://cla.js.foundation/webpack/webpack?pullRequest=13591 ?

@gthb
Copy link
Contributor Author

gthb commented Jun 21, 2021

Could you sign the CLA: https://cla.js.foundation/webpack/webpack?pullRequest=13591 ?

Done.

@sokra sokra closed this Jun 21, 2021
@sokra sokra reopened this Jun 21, 2021
@sokra sokra merged commit 710da16 into webpack:master Jun 21, 2021
@sokra
Copy link
Member

sokra commented Jun 21, 2021

Thanks

@gthb gthb deleted the patch-1 branch June 21, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants