Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove Error.captureStackTrace from all WebpackErrors #13533

Merged
merged 1 commit into from Jun 11, 2021

Conversation

markjm
Copy link
Contributor

@markjm markjm commented Jun 7, 2021

Closes ##13532

What kind of change does this PR introduce?
perf fix for errors

Did you add tests for your changes?
current error tests passing

Does this PR introduce a breaking change?
dont think so

What needs to be documented once your changes are merged?
no>

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@markjm
Copy link
Contributor Author

markjm commented Jun 7, 2021

I ran UTs locally, but not sure if I ran all different integration tests. Seems possible that some stack messages may slightly change, but lets see with this test pass

@webpack-bot
Copy link
Contributor

@markjm The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from azure (1 errors / 0 warnings) and appveyor (success) and fix these issues.

@markjm
Copy link
Contributor Author

markjm commented Jun 8, 2021

Seems one watching test failed. Wondering if its flaky because other node versions both below and above this one are fine

@markjm
Copy link
Contributor Author

markjm commented Jun 9, 2021

@sokra fyi - patching in this change gave us the 3second per recompile improvement I mentioned in the issue

@sokra sokra merged commit ac97a27 into webpack:master Jun 11, 2021
@sokra
Copy link
Member

sokra commented Jun 11, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants