Fix: broken library output by webpackPrefetch #13431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
Shinyaigeek
commented
May 23, 2021
Comment on lines
1092
to
1098
| buf2.push( | ||
| `__webpack_exports__ = ${RuntimeGlobals.onChunksLoaded}(__webpack_exports__);` | ||
| ); | ||
| if (runtimeRequirements.has(RuntimeGlobals.prefetchChunk)) { | ||
| buf2.push(`${RuntimeGlobals.onChunksLoaded}();`); | ||
| } else { | ||
| buf2.push( | ||
| `__webpack_exports__ = ${RuntimeGlobals.onChunksLoaded}(__webpack_exports__);` | ||
| ); | ||
| } |
There was a problem hiding this comment.
I thought onChunksLoaded fired by webpackPrefetch should not overwrite __webpack_exports__ because prefetchChunkHandlers return void, so I fixed issue 12993 by changing how to call onChunksLoaded with prefetchChunk.
If my approach is not correct or a test case is not enough, please feel free to close this PR or request changes.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Any chance this (or an alternative fix) will make it to prod soon? Happy to help move along if I can. |
sokra
force-pushed
the
fix/overwritten_webpack__exports_onChunksLoaded
branch
from
bc456ff
to
8ce0f24
Compare
sokra
approved these changes
Jul 16, 2021
sokra
force-pushed
the
fix/overwritten_webpack__exports_onChunksLoaded
branch
from
8ce0f24
to
c469adc
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #12993
dynamic import with
webpackPrefetch: truewill cause a broken library output in development mode.This PR will fix this issue
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
none