Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept a readonly array for configuration options #13401

Merged
merged 4 commits into from May 19, 2021
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented May 18, 2021

fixes #12818 since it's not editable

What kind of change does this PR introduce?
types fixes

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

@sokra The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from azure (4 errors / 1 warnings) and appveyor (failure) and fix these issues.

@sokra sokra merged commit 08090a9 into master May 19, 2021
@sokra sokra deleted the pascal-readonly-array branch May 19, 2021 05:03
@sokra
Copy link
Member Author

sokra commented May 19, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants