fix: resolve mismatch with types declaration and docs for resourceQuery #13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
sokra
requested changes
May 6, 2021
schemas/WebpackOptions.json
Outdated
Comment on lines
3380
to
3402
| "description": "Logical AND.", | ||
| "oneOf": [ | ||
| { | ||
| "$ref": "#/definitions/RuleSetConditions" | ||
| "$ref": "#/definitions/RuleSetCondition" | ||
| } | ||
| ] | ||
| }, | ||
| "not": { | ||
| "description": "Logical NOT.", | ||
| "oneOf": [ | ||
| { | ||
| "$ref": "#/definitions/RuleSetConditions" | ||
| "$ref": "#/definitions/RuleSetCondition" | ||
| } | ||
| ] | ||
| }, | ||
| "or": { | ||
| "description": "Logical OR.", | ||
| "oneOf": [ | ||
| { | ||
| "$ref": "#/definitions/RuleSetConditions" | ||
| "$ref": "#/definitions/RuleSetCondition" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Could you put the whole object with and, or, not into a separate definition RuleSetLogicalConditions.
This helps in generating more readable typings.
sokra
approved these changes
May 17, 2021
webpack-bot
added
PR: reviewed-approved
PR: CI-not-ok
and removed
PR: review-outdated
PR: CI-ok
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13284
I followed the suggestion provided and made changes accordingly
What kind of change does this PR introduce?
This is a bugfix
Did you add tests for your changes?
I updated the snapshot tests
Does this PR introduce a breaking change?
No, it does not
What needs to be documented once your changes are merged?
I don't think any changes need to be made to the documentation