Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker example #12939

Merged
merged 1 commit into from Mar 22, 2021
Merged

Fix worker example #12939

merged 1 commit into from Mar 22, 2021

Conversation

7rulnik
Copy link
Contributor

@7rulnik 7rulnik commented Mar 19, 2021

What kind of change does this PR introduce?

bugfix for example. Currently, publicPath from config is ignored which leads to error when loading chunks inside the worker.

image

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit ebe509a into webpack:master Mar 22, 2021
@sokra
Copy link
Member

sokra commented Mar 22, 2021

Thanks

@7rulnik 7rulnik deleted the patch-2 branch March 22, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants