Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for resolve.fallback #12827

Merged
merged 1 commit into from Mar 8, 2021
Merged

Add a test case for resolve.fallback #12827

merged 1 commit into from Mar 8, 2021

Conversation

dmattia
Copy link
Contributor

@dmattia dmattia commented Mar 6, 2021

What kind of change does this PR introduce?

This is an additional test for showing the resolve.fallback functionality, ensuring that it does not override packages that do already exist.

Did you add tests for your changes?

my changes are just a test

Does this PR introduce a breaking change?

nah

What needs to be documented once your changes are merged?

nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to add the email of your commit (david@transcend.io) to your github account and sign our CLA.

@dmattia
Copy link
Contributor Author

dmattia commented Mar 7, 2021

@sokra Awesome, thank you. I have added that email and signed the CLA

@dmattia dmattia requested a review from sokra March 7, 2021 18:51
@webpack-bot
Copy link
Contributor

Hi @dmattia.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own master branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

@sokra sokra closed this Mar 8, 2021
@sokra sokra reopened this Mar 8, 2021
@sokra sokra merged commit dace9fb into webpack:master Mar 8, 2021
@sokra
Copy link
Member

sokra commented Mar 8, 2021

Thanks

This was referenced Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants