Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update husky #12799

Merged
merged 2 commits into from Mar 1, 2021
Merged

Feature/update husky #12799

merged 2 commits into from Mar 1, 2021

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Mar 1, 2021

What kind of change does this PR introduce?

Upgrade husky and clean up setup.js.

The latest husky recommends to use prepare instead of postinstall which eliminates the need of pinst as we mentioned in #12739 (comment). I believe there's no need to wire it up in setup.js now.

Did you add tests for your changes?

Nope.

Does this PR introduce a breaking change?

Nope.

What needs to be documented once your changes are merged?

Nothing.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 9c63f11 into webpack:master Mar 1, 2021
@sokra
Copy link
Member

sokra commented Mar 1, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants