-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiCompiler parallelism and dependencies #12671
Merged
sokra
merged 6 commits into
master
from
feature/multi-compiler-parallelism-dependencies
Feb 14, 2021
Merged
MultiCompiler parallelism and dependencies #12671
sokra
merged 6 commits into
master
from
feature/multi-compiler-parallelism-dependencies
Feb 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For maintainers only:
|
add support for dependencies during watching add parallelism option for MultiCompiler
sokra
force-pushed
the
feature/multi-compiler-parallelism-dependencies
branch
from
February 13, 2021 20:02
a3e65a0
to
e7d9457
Compare
Fix for #9162? |
@sokra The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from azure (2 errors / 6 warnings) and appveyor (success) and fix these issues. |
I've created an issue to document this in webpack/webpack.js.org. |
yes fixes #9162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9162
What kind of change does this PR introduce?
feature, bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no a butfix.
dependencies is now handled in watch mode, which changes behavior a bit
What needs to be documented once your changes are merged?
dependencies
config option is largely undocumentedname
s of other configs in the same array of configs. All dependencies need to be compiled before this config starts compiling.dependencies
will invalidate the compiler when the dependency has changed and when a dependency is currently compiling or invalid this config will not compile until the dependency is done.parallelism: number
option on the configuration array now