Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer getResolve to externals #12429

Merged
merged 1 commit into from Jan 15, 2021
Merged

offer getResolve to externals #12429

merged 1 commit into from Jan 15, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 15, 2021

improve types of externals configuration option
support promises in externals

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?

  • when passing an function to externals
    • It may return a Promise now
    • There is a getResolve function in the first argument which is equal to the getResolve in loader context

improve types of externals configuration option
support promises in externals
@webpack-bot
Copy link
Contributor

webpack-bot commented Jan 15, 2021

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

I've created an issue to document this in webpack/webpack.js.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants