New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12310 #12311
Fix #12310 #12311
Conversation
For maintainers only:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test?
And please accept CLA |
I think the best would be to make the creator of that part of the code have a look on this. Otherways I'm fine with patch-package... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please also add an test case for this. You can add a case to test/cases/parsing/local-modules
.
Sorry, i don't know how to add a test for this. The files you're referring to ( |
Can you add test here https://github.com/webpack/webpack/tree/master/test/configCases |
Thanks |
The modified line was syntactically incorrect
Fixes #12310
What kind of change does this PR introduce?
bugfix for an obvious JS syntax error
Did you add tests for your changes?
Up to you guys
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?
nothing