Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12310 #12311

Merged
merged 2 commits into from Jan 15, 2021
Merged

Fix #12310 #12311

merged 2 commits into from Jan 15, 2021

Conversation

sarimarton
Copy link
Contributor

The modified line was syntactically incorrect

Fixes #12310

What kind of change does this PR introduce?

bugfix for an obvious JS syntax error

Did you add tests for your changes?

Up to you guys

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

nothing

The modified line was syntactically incorrect
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test?

@alexander-akait
Copy link
Member

And please accept CLA

@sarimarton
Copy link
Contributor Author

Can you add test?

I think the best would be to make the creator of that part of the code have a look on this. Otherways I'm fine with patch-package...

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please also add an test case for this. You can add a case to test/cases/parsing/local-modules.

@sarimarton
Copy link
Contributor Author

Looks good, please also add an test case for this. You can add a case to test/cases/parsing/local-modules.

Sorry, i don't know how to add a test for this. The files you're referring to (test/cases/parsing/local-modules/index.js), as far as I can understand, are not relevant, as they test the behavior of define calls. This is a transformation issue. There's a plain syntax error in one of the transformation templates. I suppose those templates don't have a test yet, otherwise this bug would have been uncovered earlier. But again, I might be missing something about the test suite, I've read test/README.md which didn't really help me in where to look to cover this bug.

@alexander-akait
Copy link
Member

@sokra sokra merged commit a7c0448 into webpack:master Jan 15, 2021
@sokra
Copy link
Member

sokra commented Jan 15, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 generates syntax error for 'define'
4 participants