Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12255: compileBooleanMatcher fails when prefix and suffix overlap #12256

Merged
merged 2 commits into from Dec 23, 2020
Merged

Fix #12255: compileBooleanMatcher fails when prefix and suffix overlap #12256

merged 2 commits into from Dec 23, 2020

Conversation

izaera
Copy link
Contributor

@izaera izaera commented Dec 22, 2020 •
edited

See #12255 for more info.

@ivan-zaera
fix webpack#12255
39adecf 
When looking for common suffixes, strip the common prefix (if any) from
the items, so that the method doesn't fail when they overlap.
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@izaera
Copy link
Contributor Author

izaera commented Dec 22, 2020

Note: though it says it's pending, I have already signed the CLA.

@alexander-akait
Copy link
Member

Just bug on bot side, don't worry

sokra
sokra requested changes Dec 22, 2020
View reviewed changes
lib/util/compileBooleanMatcher.js Outdated Show resolved Hide resolved
@izaera izaera mentioned this pull request Dec 22, 2020
Merged
@sokra sokra merged commit 6ac0aa5 into webpack:master Dec 23, 2020
@sokra
Copy link
Member

sokra commented Dec 23, 2020

Thanks

@izaera
Copy link
Contributor Author

izaera commented Dec 28, 2020

@sokra 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved PR: reviewed-changes-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@izaera @webpack-bot @alexander-akait @sokra @ivan-zaera