Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing of browserslist #11886

Merged
merged 18 commits into from
Nov 3, 2020
Merged

fix: parsing of browserslist #11886

merged 18 commits into from
Nov 3, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 30, 2020

What kind of change does this PR introduce?

fixes #11876, found a lot of edge cases with tests, I think we should switch from browserslist supports feature because a lot problems, babel also keep browsers in own code and use only syntax of browserslist

WIP on more fixes

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

lib/config/browserslistTargetHandler.js Outdated Show resolved Hide resolved
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to review all this numbers, but I trust you that that's fine. If you think this is done, I'll merge it.

@alexander-akait
Copy link
Member Author

Yep, let's merge, I have given comments in many places and we can always fix it in future

@vankop
Copy link
Member

vankop commented Nov 3, 2020

perhaps webpack needs some e2e browser testing =)

@alexander-akait
Copy link
Member Author

@vankop yep, it will be great 😄

@sokra sokra merged commit bd44e0c into master Nov 3, 2020
@sokra sokra deleted the issue-11876 branch November 3, 2020 14:36
@sokra
Copy link
Member

sokra commented Nov 3, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Webpack 5 a target containing IE 11 doesn't build the runtime in ES5
4 participants