-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parsing of browserslist #11886
fix: parsing of browserslist #11886
Conversation
For maintainers only:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to review all this numbers, but I trust you that that's fine. If you think this is done, I'll merge it.
Yep, let's merge, I have given comments in many places and we can always fix it in future |
perhaps webpack needs some e2e browser testing =) |
@vankop yep, it will be great 😄 |
Thanks |
What kind of change does this PR introduce?
fixes #11876, found a lot of edge cases with tests, I think we should switch from browserslist supports feature because a lot problems, babel also keep browsers in own code and use only syntax of browserslist
WIP on more fixes
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No