enable named exports for commonjs as node.js supports it now #11885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
sokra
force-pushed
the
feature/named-exports
branch
from
1ca861e
to
1f1bbda
Compare
add more test cases
sokra
force-pushed
the
feature/named-exports
branch
from
1f1bbda
to
77aed60
Compare
|
I've created an issue to document this in webpack/webpack.js.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11878
What kind of change does this PR introduce?
bugfix, feature
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
Even in .mjs named exports of commonjs modules are supported. In contrast to node.js webpack supports all possible runtime values not only static analysables.
__esModuleis intentionally not supported from.mjsfor compat reasons