Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asset info for sourceFilename and javascriptModule #11785

Merged
merged 1 commit into from Oct 22, 2020

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 22, 2020

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
two more properties in info (https://webpack.js.org/api/stats/#asset-objects)

  • sourceFilename when asset was created from a source file (potentially transformed), the original filename relative to compilation context
  • javascriptModule true, when asset is javascript and an ESM

@webpack-bot
Copy link
Contributor

webpack-bot commented Oct 22, 2020

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

I've created an issue to document this in webpack/webpack.js.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants