caniuse es6 doesn't report arrow-functions correctly #11754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie11 is an exception fixes #11753
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
When is this fix going to be published? Is it going to be part of 5.1.4? |
jsnajdr
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 22, 2020
…s can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't.
jsnajdr
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 27, 2020
…s can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't.
jsnajdr
added a commit
to WordPress/gutenberg
that referenced
this pull request
Dec 7, 2020
…s can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't.
jsnajdr
added a commit
to WordPress/gutenberg
that referenced
this pull request
Dec 7, 2020
…s can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't.
jsnajdr
added a commit
to WordPress/gutenberg
that referenced
this pull request
Dec 8, 2020
…s can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't.
gziolo
pushed a commit
to WordPress/gutenberg
that referenced
this pull request
Jan 3, 2021
…s can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't.
gziolo
added a commit
to WordPress/gutenberg
that referenced
this pull request
Jan 3, 2021
* custom-templated-path plugin: add peer dep on v5 * library-export-default plugin: add peer dep on v5 * Add target:browserslist to webpack config to specify what ES6 features can be in runtime Tells webpack whether it can use arrow functions or `let`/`const` in the generated runtime code. Will start really work only after the fix in webpack/webpack#11754 is released. Until then, arrow functions are incorrectly emitted even when they shouldn't. * Upgrade webpack and webpack-cli in package.json * Update hash-containing test snapshots for dependency-extraction-webpack-plugin * Update package-lock.json * Docs: Add changelog entry for webpack major version bump Co-authored-by: Grzegorz Ziolkowski <grzegorz@gziolo.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ie11 is an exception
fixes #11753
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing