Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport lazy require webassemblyjs using modules to webpack-4 #10132

Merged
merged 1 commit into from Dec 18, 2019

Conversation

jeffin143
Copy link
Contributor

@jeffin143 jeffin143 commented Dec 17, 2019

fixes #9859

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Existing test

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra
Copy link
Member

sokra commented Dec 17, 2019

This PR is targeting the wrong branch. It should target the webpack-4 branch

@sokra sokra changed the base branch from master to webpack-4 December 17, 2019 07:02
@sokra
Copy link
Member

sokra commented Dec 17, 2019

cherry-pick the commit onto the webpack-4 branch. Then force-push to this PR branch.

@jeffin143
Copy link
Contributor Author

cherry-pick the commit onto the webpack-4 branch. Then force-push to this PR branch.

Can u take a look now,

I tried to
git fetch --all

but that doesn't fetch webpack-4 branch for some reasons

So i just cherry picket the commit to patch branch and then force pushed it

Please let me know if that doesn't work

@sokra
Copy link
Member

sokra commented Dec 17, 2019

There should only be a single commit in the list above. Reset your branch to the webpack-4 first. git reset --hard webpack-4.

lib/wasm-async/AsyncWebAssemblyModulesPlugin.js Outdated Show resolved Hide resolved
lib/wasm/WebAssemblyModulesPlugin.js Outdated Show resolved Hide resolved
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra
Copy link
Member

sokra commented Dec 18, 2019

Thanks

@sokra sokra merged commit 5b8fbca into webpack:webpack-4 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants