New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport lazy require webassemblyjs using modules to webpack-4 #10132
Conversation
For maintainers only:
|
This PR is targeting the wrong branch. It should target the |
cherry-pick the commit onto the webpack-4 branch. Then force-push to this PR branch. |
Can u take a look now, I tried to but that doesn't fetch webpack-4 branch for some reasons So i just cherry picket the commit to patch branch and then force pushed it Please let me know if that doesn't work |
There should only be a single commit in the list above. Reset your branch to the |
9229012
to
fe71d68
Compare
aa8f954
to
77971bf
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Thanks |
fixes #9859
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
Existing test
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing