Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document webpack change: improve merging of resolve and parsing options #3197

Open
webpack-bot opened this issue Jul 17, 2019 · 2 comments
Open

Comments

@webpack-bot
Copy link

A pull request by @sokra was merged and maintainers requested a documentation change.

See pull request: webpack/webpack#9422


by rules and via loader API

Arrays overwrite by default, but can reference old value with "..."

partial backport of webpack/webpack#9126

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
Merging of Rule.resolve/Rule.parser objects has a new feature:
In array the special "..." item can now be used to reference to old value, while otherwise array values overwrite each other.
This also affects the getResolve(options) API in the loader API

@EugeneHlushko
Copy link
Member

Wow this is very useful, we had also missed one feature in docs. Wonder if it was merged before the doc Issue on PR merge feature was introduced.

@EugeneHlushko
Copy link
Member

from #3199:
Although to completely close the issue we need to figure our where to add the documentation on the getResolve resolver method. Currently its not on webpack.js.org and not on https://github.com/webpack/enhanced-resolve

@EugeneHlushko EugeneHlushko removed their assignment Jul 23, 2019
@sokra sokra added this to Not important in webpack 5 Oct 7, 2020
@sokra sokra moved this from Not important to Advanced configuration/code in webpack 5 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
webpack 5
Advanced configuration/code (not impo...
Development

No branches or pull requests

2 participants