From ef089e8cdfdce0928da0675ea62846a1ce5c9644 Mon Sep 17 00:00:00 2001 From: githoniel Date: Wed, 22 Sep 2021 16:00:05 +0800 Subject: [PATCH 1/2] fix: display file name in overlay --- client-src/overlay.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client-src/overlay.js b/client-src/overlay.js index 818c3e4d0b..900ef2e848 100644 --- a/client-src/overlay.js +++ b/client-src/overlay.js @@ -131,7 +131,8 @@ function show(messages, type) { const entryElement = document.createElement("div"); const typeElement = document.createElement("span"); - typeElement.innerText = type === "warnings" ? "Warning:" : "Error:"; + typeElement.innerText = + (type === "warnings" ? "Warning:" : "Error:") + message.file || ""; typeElement.style.color = `#${colors.red}`; // Make it look similar to our terminal. From a3d5b611c140be876c6e8c31f62bf4d385736147 Mon Sep 17 00:00:00 2001 From: githoniel Date: Thu, 23 Sep 2021 18:15:49 +0800 Subject: [PATCH 2/2] fix: fix code error --- client-src/overlay.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client-src/overlay.js b/client-src/overlay.js index 900ef2e848..609fb0a314 100644 --- a/client-src/overlay.js +++ b/client-src/overlay.js @@ -130,9 +130,9 @@ function show(messages, type) { messages.forEach((message) => { const entryElement = document.createElement("div"); const typeElement = document.createElement("span"); - + // ts-loader will output `error.file` for error file path, not in message typeElement.innerText = - (type === "warnings" ? "Warning:" : "Error:") + message.file || ""; + (type === "warnings" ? "Warning:" : "Error:") + (message.file || ""); typeElement.style.color = `#${colors.red}`; // Make it look similar to our terminal.