Backport support for configuration as Promise in Webpack v1 #698
Conversation
|
|
|
@SpaceK33z It's been a month today, I don't mean to be impatient but would it be possible to take a look at this? It's essentially a two-liner that is already in Webpack 1, just need to have it in the dev server as well. Thanks! |
|
@mathieumg Honestly I wasn't planning on doing another v1 release, since v2 is right around the corner and now we're in release candidate already. However, if I have the time this weekend I'll see if I can do another v1 release. |
|
Cool, thanks for the information. That would be appreciated to "close the book" on v1. Like I said, it's cool that the Promise config was backported from v2 to v1, it's just impractical to use it since it wasn't backported to the dev server at the same time. Thanks! |
|
@SpaceK33z Sorry to bother you, do you think it would be possible to merge this? It seems to be the last v1 PR still open. Thanks a lot! |
|
No, I'm sorry. I have been closing webpack 1 specific PR's for a while. webpack 2 is released now and we'll only focus on critical bugfixes in v1. |
|
Oh I kinda forgot that this was a bugfix not a feature. I'll see if I have some time later today. |
|
Thank you! 🎉 |
|
np, released as |
|
👍 Works. Now I can use portscanner to search for the first free port :) |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information:
Backports the fix in #419 to webpack-dev-server v1 since v1 of Webpack itself supports config as Promise. Change looks more complex than it really is, it's just because a lot of code is getting wrapped in a function.