fix: respect client.logging option for all logs
#4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
hiroppy,
knagaitsev and
anshumanv
as code owners
Codecov ReportBase: 92.06% // Head: 92.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4572 +/- ##
==========================================
+ Coverage 92.06% 92.19% +0.12%
==========================================
Files 16 16
Lines 1639 1639
Branches 617 617
==========================================
+ Hits 1509 1511 +2
+ Misses 119 117 -2
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
client-src/utils/log.js
Outdated
| @@ -18,7 +18,8 @@ setLogLevel(defaultLevel); | |||
|
|
|||
| const log = logger.getLogger(name); | |||
|
|
|||
| const logEnabledFeatures = (features) => { | |||
| const logEnabledFeatures = (features, logLevel = "info") => { | |||
| setLogLevel(logLevel); | |||
There was a problem hiding this comment.
Let's avoid it and just move logEnabledFeatures here
webpack-dev-server/client-src/index.js
Line 113 in 9baea53
alexander-akait
approved these changes
Sep 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes, updated snapshots.
Motivation / Use-Case
Fix #4566
Breaking Changes
No
Additional Info