fix: compatibility with old browsers #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
hiroppy,
knagaitsev and
anshumanv
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4544 +/- ##
==========================================
- Coverage 92.24% 92.06% -0.18%
==========================================
Files 16 16
Lines 1637 1638 +1
Branches 616 616
==========================================
- Hits 1510 1508 -2
- Misses 116 119 +3
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
client-src/utils/log.js
Outdated
| @@ -27,8 +27,8 @@ const logEnabledFeatures = (features) => { | |||
| let logString = "Server started:"; | |||
|
|
|||
| // Server started: Hot Module Replacement enabled, Live Reloading enabled, Overlay disabled. | |||
| for (const [key, value] of Object.entries(features)) { | |||
| logString += ` ${key} ${value ? "enabled" : "disabled"},`; | |||
| for (const key of Object.keys(features)) { | |||
There was a problem hiding this comment.
Still new syntax https://caniuse.com/mdn-javascript_statements_for_of, let rewrite on simple loop
There was a problem hiding this comment.
Actually, this will be converted to for loop by babel:
snitin315
force-pushed
the
fix/old-browser
branch
from
af39b70
to
24e25cc
Compare
alexander-akait
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Already present.
Motivation / Use-Case
Fix #4543
Object.keysis compatible with IE9,10, and 11 - https://caniuse.com/?search=object.keysBreaking Changes
No
Additional Info
No