Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use latest sockjs-client package, once they've updated to use latest eventsource package (CVE-2022-1650) #4460

Closed
nathanmillar16 opened this issue May 26, 2022 · 7 comments

Comments

@nathanmillar16
Copy link

nathanmillar16 commented May 26, 2022

Bug report

webpack-dev-server has sockjs-client as a dependency. sockjs-client has a dependency eventsource. sockjs-client needs to update to latest event soruce. Once that is done, webpack-dev-server will need to update to latest sockjs-client

sockjs-client will need to use eventsource 2.0.2. Lower versions have a critical vulnerability.

Actual Behavior

Vulnerability scanners (with up to date definitions), perform a scan against webpack-dev-server. Notice the failure for eventsource 1.1.0

Expected Behavior

Use a vulnerability scanners (with up to date definitions), it should pass with eventsource, sockjs-client and webpack-dev-server

How Do We Reproduce?

Use a vulnerability scanner (with up to date definitions), perform a scan against webpack-dev-server. Notice the failure for eventsource 1.1.0

@nathanmillar16 nathanmillar16 changed the title Update to use latest sockjs-client package, once they've updated to use latest Update to use latest sockjs-client package, once they've updated to use latest eventsource package May 26, 2022
@nathanmillar16
Copy link
Author

This change is dependant on one of the following PRs:

sockjs/sockjs-client#590

sockjs/sockjs-client#591

@ahmetalsan
Copy link

I have same error. Please help

@nathanmillar16 nathanmillar16 changed the title Update to use latest sockjs-client package, once they've updated to use latest eventsource package Update to use latest sockjs-client package, once they've updated to use latest eventsource package (CVE-2022-1650) May 26, 2022
@nathanmillar16
Copy link
Author

@alexander-akait
Copy link
Member

We should wait the fix in sockjs-client, we can't fix it here

@nathanmillar16
Copy link
Author

We should wait the fix in sockjs-client, we can't fix it here

Yes, that's right. I raised this issue so people are aware and stated in original bug comment that it is pending a fix in sockjs

@nathanmillar16
Copy link
Author

sockjs-client have now implemented this fix. (sockjs/sockjs-client#590)

webpack-dev-server can now consume the newest version of sockjs-client

@alexander-akait
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants