Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump memfs to 3.4.2 #4440

Closed
ivanbacher opened this issue May 17, 2022 · 3 comments
Closed

Bump memfs to 3.4.2 #4440

ivanbacher opened this issue May 17, 2022 · 3 comments

Comments

@ivanbacher
Copy link

Bug report

installed node v18.2.0

Dev server randomly dies with the following error message:

node:events:505
      throw er; // Unhandled 'error' event
      ^

TypeError: Cannot set property closed of #<Readable> which has only a getter
    at FsReadStream.close (/Users/.../node_modules/memfs/lib/volume.js:2047:17)
    at FsReadStream._destroy (/Users/.../node_modules/memfs/lib/volume.js:2032:10)
    at _destroy (node:internal/streams/destroy:109:10)
    at class_1.destroy (node:internal/streams/destroy:71:5)
    at class_1.<anonymous> (/Users/.../node_modules/memfs/lib/volume.js:1962:22)
    at class_1.emit (node:events:539:35)
    at endReadableNT (node:internal/streams/readable:1344:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at runNextTicks (node:internal/process/task_queues:64:3)
    at process.processImmediate (node:internal/timers:442:9)
Emitted 'error' event on class_1 instance at:
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at runNextTicks (node:internal/process/task_queues:64:3)
    at process.processImmediate (node:internal/timers:442:9)

Node.js v18.2.0

Found this issue on memfs library:

🎉 This issue has been resolved in version 3.4.2 🎉

Actual Behavior

Expected Behavior

How Do We Reproduce?

Please paste the results of npx webpack-cli info here, and mention other relevant information

@alexander-akait
Copy link
Member

Close in favor webpack/webpack-dev-middleware#1268, because it is used in webpack-dev-middleware

@ivanbacher
Copy link
Author

Sorry, this is actually an issue with webpack-dev-middleware. Also created a bug report on that repo. Once memfs gets updated there, will probably need to bump webpack-dev-middleware to newest version.

@alexander-akait
Copy link
Member

alexander-akait commented May 17, 2022

When we done release webpack-dev-middleware you can update own deps, I don't think we need to do release for each patch in vendor libraries here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants