ci: fix for windows #4229
ci: fix for windows #4229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4229 +/- ##
==========================================
+ Coverage 92.34% 92.47% +0.12%
==========================================
Files 14 14
Lines 1541 1541
Branches 590 590
==========================================
+ Hits 1423 1425 +2
+ Misses 109 107 -2
Partials 9 9
Continue to review full report at Codecov.
|
|
Weird 😕 |
|
We should build client using webpack v5 for webpack v4 |
|
How do we do that? It seems |
|
@snitin315 Let's install webpack v5 then build client, then install webpack v4 and skip client generation at all |
package.json
Outdated
| @@ -25,7 +25,8 @@ | |||
| "commitlint": "commitlint --from=master", | |||
| "build:client": "rimraf ./client/* && babel client-src/ --out-dir client/ --ignore \"client-src/webpack.config.js\" --ignore \"client-src/modules\" && webpack --config client-src/webpack.config.js", | |||
| "build:types": "rimraf ./types/* && tsc --declaration --emitDeclarationOnly --outDir types && node ./scripts/extend-webpack-types.js && prettier \"types/**/*.ts\" --write && prettier \"types/**/*.ts\" --write", | |||
| "build": "npm-run-all -p \"build:**\"", | |||
| "build": "npm run build:client", | |||
| "postbuild": "npm run-all -p \"build:**\"", | |||
There was a problem hiding this comment.
Better to keep this as it, there are bugs in yarn with this, just improve CI file
There was a problem hiding this comment.
npm link webpack-dev-server is always running npm run build, and npm run build:types is failing with webpack-4
There was a problem hiding this comment.
I understand this, we should search workarounds, we can try --ignore-scripts
There was a problem hiding this comment.
I am searching for workarounds, We already have --ignore-scripts it only ignores pre and post scripts so it will ignore prebuild and postbuild scripts only.
There was a problem hiding this comment.
Seems issue with the latest npm version, using node v14 with webpack 4 works fine.
There was a problem hiding this comment.
In theory we create scripts which remove command from package.json and run it on CI
snitin315
force-pushed
the
ci-fix-windows
branch
from
c52dbc3
to
38286b5
Compare
|
@snitin315 let's uncomment, we will fix flacky tests in future |
snitin315
requested review from
anshumanv,
hiroppy and
knagaitsev
as code owners
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Breaking Changes
Additional Info