Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for WEBPACK_SERVE env variable #4125

Merged
merged 1 commit into from Dec 21, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

refactor

Motivation / Use-Case

add e2e test for WEBPACK_SERVE env variable

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #4125 (3a7dc0a) into master (c9b959f) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4125      +/-   ##
==========================================
+ Coverage   92.54%   92.68%   +0.13%     
==========================================
  Files          14       14              
  Lines        1462     1462              
  Branches      552      552              
==========================================
+ Hits         1353     1355       +2     
+ Misses        101       99       -2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b959f...3a7dc0a. Read the comment docs.

@alexander-akait alexander-akait merged commit 37b73d5 into master Dec 21, 2021
@alexander-akait alexander-akait deleted the e2e-webpack-serve-env branch December 21, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants