Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to pass all options from chokidar #4025

Merged
merged 8 commits into from Nov 25, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated snapshots.

Motivation / Use-Case

  • Better defaults
  • allow to pass all options from chokidar for static.watch and watchFiles.options

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #4025 (ea12406) into master (d104b58) will increase coverage by 0.02%.
The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
+ Coverage   92.71%   92.74%   +0.02%     
==========================================
  Files          14       14              
  Lines        1441     1474      +33     
  Branches      530      546      +16     
==========================================
+ Hits         1336     1367      +31     
- Misses         97       99       +2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/Server.js 94.09% <96.92%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d104b58...ea12406. Read the comment docs.

lib/Server.js Outdated Show resolved Hide resolved
lib/Server.js Outdated Show resolved Hide resolved
@alexander-akait alexander-akait merged commit 5026601 into master Nov 25, 2021
@alexander-akait alexander-akait deleted the feat/allow-chokidar-opts branch November 25, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants