Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show deprecation warning for https/http2 option #4003

Merged
merged 2 commits into from Nov 5, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

show deprecation warning for https/http2 option.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #4003 (6b7e78e) into master (61e572e) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4003      +/-   ##
==========================================
- Coverage   92.74%   92.62%   -0.12%     
==========================================
  Files          14       14              
  Lines        1406     1411       +5     
  Branches      516      519       +3     
==========================================
+ Hits         1304     1307       +3     
- Misses         94       96       +2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/Server.js 94.02% <100.00%> (+0.02%) ⬆️
lib/servers/WebsocketServer.js 91.42% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e572e...6b7e78e. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge it using feat: because it is deprecation

@snitin315 snitin315 changed the title fix: show deprecation warning for https/http2 option feat: show deprecation warning for https/http2 option Nov 3, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add example for https/http2 and server options, so we will provide them in our changelog for easy migration?

@snitin315
Copy link
Member Author

Added examples in #4007.

Also, we can link to docs in migration for more information - https://webpack.js.org/configuration/dev-server/#devserverserver

@alexander-akait alexander-akait merged commit 521cf85 into master Nov 5, 2021
@alexander-akait alexander-akait deleted the fix/warn-server-https branch November 5, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants