feat: add --web-socket-server-type option for CLI
#4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4001 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 14 14
Lines 1405 1405
Branches 516 516
=======================================
Hits 1301 1301
Misses 96 96
Partials 8 8
Continue to review full report at Codecov.
|
| @@ -80,6 +80,7 @@ Options: | |||
| --client-web-socket-url-password <value> Tells clients connected to devServer to use the provided password to authenticate. | |||
| --web-socket-server <value> Allows to set web socket server and options (by default 'ws'). | |||
| --no-web-socket-server Negative 'web-socket-server' option. | |||
| --web-socket-server-type <value> Allows to set web socket server and options (by default 'ws'). | |||
There was a problem hiding this comment.
@snitin315 Can we mark --web-socket-server <value> is deprecated and add TODO?
snitin315
force-pushed
the
feat/web-socket-server-type
branch
from
615258e
to
5300e33
Compare
alexander-akait
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
add
--web-socket-server-typeoption for CLI. Add todo to remove--web-spcket-server.Breaking Changes
None
Additional Info
No