Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code for consistency #3795

Merged
merged 1 commit into from Sep 5, 2021
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

refactor code for consistency. options is already destructured above.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #3795 (e9e7564) into master (596c042) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3795      +/-   ##
==========================================
+ Coverage   92.88%   93.03%   +0.15%     
==========================================
  Files          14       14              
  Lines        1321     1321              
  Branches      463      463              
==========================================
+ Hits         1227     1229       +2     
+ Misses         87       85       -2     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.84% <100.00%> (ø)
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596c042...e9e7564. Read the comment docs.

@snitin315 snitin315 merged commit c11c759 into master Sep 5, 2021
@snitin315 snitin315 deleted the refactor-code-use-options branch September 5, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant