Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update webpack #2176

Merged
merged 1 commit into from Aug 5, 2019
Merged

chore(deps): update webpack #2176

merged 1 commit into from Aug 5, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Aug 4, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

webpack@4.39.1 cannot exit when a platform is Linux. Currently, all PRs are down so I add --forceExit flag to jest as temporary.

diff: webpack/webpack@v4.39.0...v4.39.1

closes: #2173

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #2176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2176   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          33       33           
  Lines        1265     1265           
  Branches      363      363           
=======================================
  Hits         1188     1188           
+ Misses         73       71    -2     
- Partials        4        6    +2
Impacted Files Coverage Δ
client-src/clients/WebsocketClient.js 57.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a1f29...84ed1bf. Read the comment docs.

@hiroppy hiroppy marked this pull request as ready for review August 4, 2019 14:42
@alexander-akait alexander-akait merged commit a28800d into master Aug 5, 2019
@alexander-akait alexander-akait deleted the feature/fix-webpack branch August 5, 2019 08:49
@alexander-akait alexander-akait restored the feature/fix-webpack branch August 5, 2019 08:49
@alexander-akait alexander-akait deleted the feature/fix-webpack branch August 5, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants