Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package) Add url for compatibility with webpack@5 (#1598) #1599

Merged
merged 1 commit into from Dec 13, 2018

Conversation

glenjamin
Copy link
Contributor

@glenjamin glenjamin commented Dec 13, 2018

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Didn't add tests, as this would require CI to run against webpack v5 to exhibit the problem.

Can reproduce the issue and confirm the fix by installing webpack v5 into this package and running the prepare script.

Motivation / Use-Case

fixes #1598

Breaking Changes

none

Additional Info

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #1599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files          10       10           
  Lines         671      671           
=======================================
  Hits          497      497           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadae5d...8f3b47f. Read the comment docs.

@alexander-akait alexander-akait merged commit 68dd49a into webpack:master Dec 13, 2018
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack 5 install 'url' and 'events' as a dependency
2 participants