chore(tests): updated test regex, some helper scripts #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated test regex to include all tests, added some helper scripts ISSUES CLOSED: webpack#808
Added scripts to run specific tests ISSUES CLOSED: Added scripts to run specific tests
ematipico
suggested changes
Mar 28, 2019
fix tests on node 6 ISSUES CLOSED: webpack#808
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
Ah! I forgot to test on nvm :( Removed! 👍 💯 |
one more async down
misterdev
approved these changes
Mar 28, 2019
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
update text to run packages text
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@ematipico updated! 💯 |
dhruvdutt
approved these changes
Mar 29, 2019
ematipico
approved these changes
Mar 29, 2019
misterdev
pushed a commit
to misterdev/webpack-cli
that referenced
this pull request
Apr 23, 2019
ISSUES CLOSED: webpack#808 <!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> **What kind of change does this PR introduce?** Updated test regex to run all tests, added some helper scripts for running tests <!-- E.g. a bugfix, feature, refactoring, build related change, etc… --> **Did you add tests for your changes?** Yes **If relevant, did you update the documentation?** Yes **Summary** * Updated tests regex to run all tests * Added helper scripts to run cli and package tests separately <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> <!-- Try to link to an open issue for more information. --> **Does this PR introduce a breaking change?** No <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. --> **Other information**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #808
What kind of change does this PR introduce?
Updated test regex to run all tests, added some helper scripts for running tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No
Other information