Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using cjs as default config #1775

Merged
merged 3 commits into from Aug 28, 2020
Merged

Conversation

anshumanv
Copy link
Member

Fixes #1165

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
No need

Summary

  • Adds support for using cjs as default config.
  • Add default config tests

Does this PR introduce a breaking change?
No

Other information
Refer discussion in #1165

@anshumanv anshumanv requested a review from a team as a code owner August 27, 2020 16:04
@anshumanv
Copy link
Member Author

CI freeze 😞

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@anshumanv anshumanv merged commit aaaa07b into webpack:next Aug 28, 2020
@anshumanv anshumanv deleted the cjs-default branch August 28, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support webpack.config.cjs by default
6 participants