feat: support multiple env params #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in near future |
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
anshumanv
commented
Jul 31, 2020
| @@ -1 +1,3 @@ | |||
| console.log('chuntaro'); | |||
| // eslint-disable-next-line no-undef | |||
There was a problem hiding this comment.
need disable because envMessage is not present in scope but instead coming from env
alexander-akait
previously approved these changes
Jul 31, 2020
webpack-bot
added
PR: reviewed-approved
PR: review-outdated
and removed
PR: review-outdated
PR: reviewed-approved
labels
anshumanv
commented
Jul 31, 2020
| @@ -10,6 +13,8 @@ module.exports = (env) => { | |||
| return { | |||
| entry: './a.js', | |||
| mode: 'development', | |||
| stats: env.verboseStats ? 'verbose' : 'normal', | |||
| plugins: [new DefinePlugin({ envMessage: env.envMessage ? JSON.stringify('env message present') : false })], | |||
There was a problem hiding this comment.
need JSON.stringify, can't pass string directly 😞
snitin315
approved these changes
Aug 1, 2020
alexander-akait
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Having multiple env is a common use case so a single arg won't suffice, hence added support for multiple
Does this PR introduce a breaking change?
No
Other information