chore: prevent weird behaviour of pre-commit hook

[jamesgeorge007]

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary
Fixed the weird behavior of pre-commit hook as mentioned in #956

Fixes #956

Does this PR introduce a breaking change?

Nope

Other information
N/A

[ematipico]

In order to solve the issue, we have to follow this recommendation: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md#usage-with-prettier

[jamesgeorge007]

@ematipico Are these rules to be included within .eslintrc.js?

{
  "extends": [
    "plugin:@typescript-eslint/recommended",
    "prettier",
    "prettier/@typescript-eslint"
  ]
}

Is this the required workaround 🤔

[ematipico]

We have to include this in all the .eslintrc files we have inside the repository. It's not a workaround, it's correct integration between @typescript-eslint and prettier

[webpack-bot]

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

[ematipico]

These changes should be applied to the libraries inside packages folder. You see, the change that you are applying are for TypeScript files but the configuration you are changing are for JavaScript files.

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[rishabh3112]

Looks great to me 👍
Although, why are there changes to the lock files when no new packages are neither added, updated or deleted?

[jamesgeorge007]

@rishabh3112 CI was failing without those lock file changes.