feat: update commander to v9 #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
update-commander
branch
from
e4d5e23
to
9f7e78b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #3460 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 22 22
Lines 1587 1588 +1
Branches 447 447
=======================================
+ Hits 1449 1450 +1
Misses 138 138
Continue to review full report at Codecov.
|
| [webpack-cli] Run 'webpack --help' to see available commands and options" | ||
| `; | ||
|
|
||
| exports[`unknown behaviour should log an error if an unknown flag is passed and suggests the closest match to an unknown flag using "b" command: stdout 1`] = `""`; | ||
|
|
||
| exports[`unknown behaviour should log an error if an unknown flag is passed and suggests the closest match to an unknown flag using "bundle" command: stderr 1`] = ` | ||
| "[webpack-cli] Error: Unknown option '--entyr' | ||
| [webpack-cli] Did you mean '--entry'? | ||
| (Did you mean --entry?) |
There was a problem hiding this comment.
Will be great to have [webpack-cli] prefix here, is there the places where we can hook?
There was a problem hiding this comment.
Yes, we can disable it with this.program.showSuggestionAfterError(false); and keep our own logic.
|
@alexander-akait Done 👍🏻 |
snitin315
added a commit
that referenced
this pull request
Nov 6, 2022
snitin315
added a commit
that referenced
this pull request
Nov 8, 2022
alexander-akait
pushed a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Updated snapshots and tests.
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
No