Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show default value in help output if available #2814

Merged
merged 2 commits into from Jul 15, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
Manual testing
If relevant, did you update the documentation?

Summary
show default value in help output if provided in the option object.

Does this PR introduce a breaking change?
None

Other information
No

@codecov
Copy link

codecov bot commented Jul 4, 2021

Codecov Report

Merging #2814 (2c60e03) into master (0fa5b70) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
+ Coverage   93.99%   94.11%   +0.11%     
==========================================
  Files          32       32              
  Lines        1715     1715              
  Branches      495      495              
==========================================
+ Hits         1612     1614       +2     
+ Misses        103      101       -2     
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 96.87% <100.00%> (+0.10%) ⬆️
packages/generators/src/addon-generator.ts 91.93% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa5b70...2c60e03. Read the comment docs.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there tests for this?

@snitin315
Copy link
Member Author

None at present. I will see if I can add one.

@alexander-akait
Copy link
Member

@snitin315 yep, let's add test, we can do it in api directory of tests

@alexander-akait
Copy link
Member

@snitin315 friendly ping

@rishabh3112 rishabh3112 merged commit 7f50948 into master Jul 15, 2021
@rishabh3112 rishabh3112 deleted the fix/help-default-value branch July 15, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants