Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more information #2683

Merged
merged 2 commits into from May 1, 2021
Merged

docs: add more information #2683

merged 2 commits into from May 1, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
Docs

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Yes
Summary

Add more useful information.

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner May 1, 2021 09:15
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #2683 (edc057d) into master (0fc3eec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2683   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          30       30           
  Lines        1526     1526           
  Branches      432      432           
=======================================
  Hits         1465     1465           
  Misses         61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc3eec...edc057d. Read the comment docs.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't maintain full documentation in 4 places, I don't think many people will even arrive at this readme.

We should keep this at root if at all we want this here given it's already in the docs page

@snitin315
Copy link
Member Author

This readme renders on the official npm page https://www.npmjs.com/package/webpack-cli, nevertheless a link to the official docs https://webpack.js.org/api/cli/ should be present.

@anshumanv
Copy link
Member

yep link makes sense 👍

@alexander-akait
Copy link
Member

Sorry, too fast, feel free to send other PR and improve it more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants