Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create and new alias for init #2616

Merged
merged 5 commits into from Apr 13, 2021
Merged

feat: add create and new alias for init #2616

merged 5 commits into from Apr 13, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 12, 2021

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes WIP
Summary
Fixes #2599

create new aliases - create, new

Latest usage - webpack init|create|new|c|n [generation-path] [options]

Does this PR introduce a breaking change?
No

Other information
No

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update OPTIONS.md?

@snitin315
Copy link
Member Author

Yes just fixing one issue, now init is printing three times in help output.

Screenshot 2021-04-12 at 4 32 54 PM

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #2616 (6389e7a) into master (debe93b) will increase coverage by 6.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
+ Coverage   89.03%   95.11%   +6.07%     
==========================================
  Files          31       31              
  Lines        1514     1514              
  Branches      431      431              
==========================================
+ Hits         1348     1440      +92     
+ Misses        166       74      -92     
Impacted Files Coverage Δ
packages/generators/src/index.ts 100.00% <ø> (ø)
packages/webpack-cli/lib/webpack-cli.js 96.14% <100.00%> (+9.62%) ⬆️
packages/serve/src/startDevServer.ts 87.30% <0.00%> (+4.76%) ⬆️
packages/serve/src/index.ts 91.22% <0.00%> (+7.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debe93b...6389e7a. Read the comment docs.

@alexander-akait
Copy link
Member

I will finish PR, thanks for help

@alexander-akait
Copy link
Member

Found other bug, webpack help new is not working

@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Rename init to create
3 participants