Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve tests for --merge #2399

Merged
merged 1 commit into from Feb 2, 2021
Merged

test: improve tests for --merge #2399

merged 1 commit into from Feb 2, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
test

Did you add tests for your changes?
YES
If relevant, did you update the documentation?
NO
Summary
improve existing tests and add one more case for merging more than two configs.

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner February 2, 2021 12:45
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future please focus on coverage on tests which increase coverage, in future we migrate on snapshot tests with options, so it will be easy to catch problem, anyway thanks

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #2399 (bbc67b2) into master (ad1a6b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2399   +/-   ##
=======================================
  Coverage   71.74%   71.74%           
=======================================
  Files          47       47           
  Lines        2173     2173           
  Branches      573      573           
=======================================
  Hits         1559     1559           
  Misses        614      614           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1a6b8...bbc67b2. Read the comment docs.

@snitin315 snitin315 merged commit b50d71b into master Feb 2, 2021
@snitin315 snitin315 deleted the test/merge branch February 2, 2021 13:54
snitin315 added a commit to snitin315/webpack-cli that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants