Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: publicPath #2271

Merged
merged 3 commits into from Dec 30, 2020
Merged

tests: publicPath #2271

merged 3 commits into from Dec 30, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 28, 2020

What kind of change does this PR introduce?

tests

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

No need

Summary

fixes #2242

Does this PR introduce a breaking change?

No

Other information

WIP, need set devServer.publicPath when publicPath is passed

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #2271 (8ba8114) into master (0595603) will increase coverage by 0.09%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
+ Coverage   68.00%   68.09%   +0.09%     
==========================================
  Files          63       63              
  Lines        2435     2442       +7     
  Branches      547      552       +5     
==========================================
+ Hits         1656     1663       +7     
  Misses        779      779              
Impacted Files Coverage Δ
packages/serve/src/startDevServer.ts 84.00% <96.29%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0595603...8ba8114. Read the comment docs.

anshumanv
anshumanv previously approved these changes Dec 29, 2020
snitin315
snitin315 previously approved these changes Dec 29, 2020
@webpack-bot
Copy link

@alexander-akait Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@alexander-akait
Copy link
Member Author

Found bugs with multi compiler mode, WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputPath is not respected with 4.2.0
4 participants