Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the --help option is working without webpack-dev-server #2267

Merged
merged 5 commits into from Dec 28, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 27, 2020

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

partial, hard to tests due yarn workspaces

If relevant, did you update the documentation?

No need

Summary

Allow to lazy installation and loading options for commands

Does this PR introduce a breaking change?

No

Other information

fixes #2266

@alexander-akait
Copy link
Member Author

TODO fix: webpack serve --open without webpack-dev-server

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #2267 (c031719) into master (952a188) will increase coverage by 0.22%.
The diff coverage is 77.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
+ Coverage   67.82%   68.04%   +0.22%     
==========================================
  Files          63       63              
  Lines        2415     2438      +23     
  Branches      544      548       +4     
==========================================
+ Hits         1638     1659      +21     
- Misses        777      779       +2     
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 90.99% <68.42%> (-0.80%) ⬇️
packages/serve/src/index.ts 66.10% <85.71%> (+7.08%) ⬆️
packages/generators/src/index.ts 100.00% <100.00%> (ø)
packages/info/src/index.ts 100.00% <100.00%> (ø)
packages/init/src/index.ts 90.90% <100.00%> (ø)
packages/migrate/src/index.ts 88.88% <100.00%> (ø)
...kages/webpack-cli/lib/utils/prompt-installation.js 57.69% <100.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952a188...c031719. Read the comment docs.

@alexander-akait
Copy link
Member Author

Really hard to tests due we use execa, plus removing and installation again break other tests, I will thinks about it more deeply when we focus on coverage (i.e. 4.5 version), tested manually

@@ -1,8 +0,0 @@
const WebpackCLITestPlugin = require('../utils/webpack-cli-test-plugin');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this test in core-flags, so it is duplicate

@alexander-akait alexander-akait merged commit 1dae54d into master Dec 28, 2020
@alexander-akait alexander-akait deleted the issue-2266 branch December 28, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx webpack --help should not ask user to install webpack-dev-server
2 participants