Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect the infrastructureLogging.level option #2144

Merged
merged 6 commits into from Dec 1, 2020

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

No change existing, WIP

If relevant, did you update the documentation?

No

Summary

fixes #2019

Does this PR introduce a breaking change?

No, it is feature

Other information

No

@alexander-akait
Copy link
Member Author

/cc @piecyk something missed?

piecyk
piecyk previously approved these changes Nov 28, 2020
Copy link
Contributor

@piecyk piecyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alexander-akait
Copy link
Member Author

Need a lot of changes in tests 😞 WIP

@piecyk
Copy link
Contributor

piecyk commented Nov 30, 2020

Need a lot of changes in tests 😞 WIP

Yep, that's why the #2036 pr had so many changes.

@alexander-akait
Copy link
Member Author

/cc @snitin315 we need more tests refactor:

  • each tests should check exitCode/stderr/stdout
  • some tests from core-flag is invalid (i.e. used invalid value)
  • we need avoid fs checks there it is unnecessary

you can help me with this

@snitin315
Copy link
Member

Yes I can help. Should I do it in this PR or separate?

@alexander-akait
Copy link
Member Author

separate

snitin315
snitin315 previously approved these changes Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #2144 (1de1a33) into master (08d4355) will increase coverage by 2.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2144      +/-   ##
==========================================
+ Coverage   66.15%   68.43%   +2.27%     
==========================================
  Files          72       72              
  Lines        2340     2341       +1     
  Branches      516      516              
==========================================
+ Hits         1548     1602      +54     
+ Misses        792      739      -53     
Impacted Files Coverage Δ
packages/webpack-cli/lib/plugins/CLIPlugin.js 100.00% <100.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 96.19% <100.00%> (+12.73%) ⬆️
packages/migrate/src/index.ts 90.24% <0.00%> (+4.87%) ⬆️
packages/utils/src/prop-types.ts 100.00% <0.00%> (+16.66%) ⬆️
packages/webpack-cli/lib/utils/to-kebab-case.js 100.00% <0.00%> (+33.33%) ⬆️
packages/webpack-cli/lib/utils/cli-flags.js 100.00% <0.00%> (+53.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d4355...1de1a33. Read the comment docs.

@alexander-akait
Copy link
Member Author

Hata macos and watching, we really need to stability this tests

@alexander-akait alexander-akait merged commit 7daccc7 into master Dec 1, 2020
@alexander-akait alexander-akait deleted the issue-2019 branch December 1, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] How to remove logging in watch mode?
4 participants