Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pnpm support for package installation #2040

Merged
merged 3 commits into from Nov 6, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary

add pnpm support for package installation

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner November 5, 2020 02:13
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #2040 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
- Coverage   69.01%   69.01%   -0.01%     
==========================================
  Files          85       85              
  Lines        2443     2446       +3     
  Branches      493      494       +1     
==========================================
+ Hits         1686     1688       +2     
- Misses        757      758       +1     
Impacted Files Coverage Δ
...kages/webpack-cli/lib/utils/prompt-installation.js 33.33% <ø> (ø)
...kages/webpack-cli/lib/utils/get-package-manager.js 83.33% <66.66%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a786301...3a59811. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@alexander-akait
Copy link
Member

/cc @webpack/cli-team

1 similar comment
@snitin315
Copy link
Member Author

/cc @webpack/cli-team

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, needs coverage bump.

@alexander-akait
Copy link
Member

@rishabh3112 Changing Coverage 69.01% 69.01% -0.01% is normal

@alexander-akait
Copy link
Member

@snitin315 Let's improve it in webpack too for webpack-cli https://github.com/webpack/webpack/blob/master/bin/webpack.js, big thanks for helping

@alexander-akait alexander-akait merged commit 46cba36 into master Nov 6, 2020
@alexander-akait alexander-akait deleted the feat/pnpm-support branch November 6, 2020 12:38
@snitin315
Copy link
Member Author

@snitin315 Let's improve it in webpack too for webpack-cli https://github.com/webpack/webpack/blob/master/bin/webpack.js, big thanks for helping

Sure, I will send a PR.

@alexander-akait
Copy link
Member

@snitin315 big thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants