Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure codecov reporting #2032

Merged
merged 5 commits into from Nov 4, 2020
Merged

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
No
Summary
Configure reporting of codecov

Does this PR introduce a breaking change?
No

Other information
related to #1899

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #2032 into master will increase coverage by 9.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
+ Coverage   59.44%   68.99%   +9.55%     
==========================================
  Files         102       85      -17     
  Lines        2611     2422     -189     
  Branches      518      489      -29     
==========================================
+ Hits         1552     1671     +119     
+ Misses        931      751     -180     
+ Partials      128        0     -128     
Impacted Files Coverage Δ
packages/migrate/src/bannerPlugin/bannerPlugin.ts 42.85% <0.00%> (ø)
...removeDeprecatedPlugins/removeDeprecatedPlugins.ts 50.00% <0.00%> (ø)
prettier.config.js
commitlint.config.js
setupTest.js
smoketests/watch/watch.single.smoketest.js
lint-staged.config.js
scripts/prepareSuite.js
...grate/src/namedModulesPlugin/namedModulesPlugin.ts
packages/generators/templates/index.js
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0038ff2...cf65b00. Read the comment docs.

@rishabh3112 rishabh3112 mentioned this pull request Nov 4, 2020
@snitin315
Copy link
Member

CI seems super slow 😞

@rishabh3112
Copy link
Member Author

CI seems super slow

Yup, but unrelated to this PR as individual jobs are taking same amount of time as they where before. Issue is that the less number of jobs are not running simultaneously per PR because of sudden increase of commits in repository as a whole.

@snitin315
Copy link
Member

hmm, I think we should cancel the previous run manually if we push a new commit.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@alexander-akait alexander-akait merged commit 2814365 into master Nov 4, 2020
@alexander-akait alexander-akait deleted the feat/configure-codecov branch November 4, 2020 11:59
@alexander-akait
Copy link
Member

@rishabh3112 Can we focus on skip test

@webpack/cli-team Also we should improve coverage - just more tests, ideally have 95-100% coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants